Re: Small issues with CREATE TABLE COMPRESSION - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Small issues with CREATE TABLE COMPRESSION
Date
Msg-id YJMyr0feaqIuqJQz@paquier.xyz
Whole thread Raw
In response to Re: Small issues with CREATE TABLE COMPRESSION  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Small issues with CREATE TABLE COMPRESSION
List pgsql-hackers
On Wed, May 05, 2021 at 09:59:41AM -0400, Robert Haas wrote:
> TAP tests have a facility for conditionally skipping tests; see
> perldoc Test::More. That's actually superior to what you can do with
> pg_regress. We'd need to come up with some logic to determine when to
> skip or not, though. Perhaps the easiest method would be to have the
> relevant Perl script try to create a table with an lz4 column. If that
> works, then perform the LZ4-based tests. If it fails, check the error
> message. If it says anything that LZ4 is not supported by this build,
> skip those tests. If it says anything else, die.

There is a simpler and cheaper method to make the execution of TAP
test conditional.  As in src/test/ssl/t/002_scram.pl for channel
binding, I think that you could use something like
check_pg_config("#define HAVE_LIBLZ4 1") and use its result to decide
which tests to skip or not.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: v14 mechanical code beautification patches
Next
From: Robert Haas
Date:
Subject: Re: .ready and .done files considered harmful