Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids
Date
Msg-id YIZ6IRF7o0y6AVni@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids  ("Joel Jacobson" <joel@compiler.org>)
Responses Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids  ("Joel Jacobson" <joel@compiler.org>)
List pgsql-hackers
On Fri, Apr 23, 2021 at 09:33:36AM +0200, Joel Jacobson wrote:
> Also, since this is a problem also in v13 maybe this should also be
> back-ported?  I think it's a bug since both
> pg_identify_object_as_address() and event triggers exists in v13, so
> the function should work there as well, otherwise users would need
> to do work-arounds for event triggers.

No objections from here to do something in back-branches.  We cannot
have a test for event triggers in object_address.sql and it would be
better to keep it in a parallel set (see 676858b for example).  Could
you however add a small test for that in event_trigger.sql?  It would
be good to check after all three functions pg_identify_object(),
pg_identify_object_as_address() and pg_get_object_address().
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] add concurrent_abort callback for output plugin
Next
From: Yuya Watari
Date:
Subject: Re: Performance Evaluation of Result Cache by using TPC-DS