Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Date
Msg-id YHrc24AgJQ6tQ1q0@paquier.xyz
Whole thread Raw
In response to Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On Thu, Apr 15, 2021 at 09:12:52PM -0400, Andrew Dunstan wrote:
> It's worked on fairywren, I will double check on drongo and if all is
> well will commit.

Thanks Andrew.  For the archive's sake, this has been committed as of
3c5b068.

While reading the commit, I have noticed that you used SEEK_SET
instead of 0 as I did in my own patch.  That makes the code easier to
understand.  Could it be better to apply the same style to all the
perl scripts doing some seek() calls?  Please see the attached.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Esteban Zimanyi
Date:
Subject: Re: Error when defining a set returning function
Next
From: Amit Kapila
Date:
Subject: Re: Table refer leak in logical replication