Re: INCLUDING COMPRESSION - Mailing list pgsql-docs

From Michael Paquier
Subject Re: INCLUDING COMPRESSION
Date
Msg-id YHerAixOhfR1ryXa@paquier.xyz
Whole thread Raw
In response to INCLUDING COMPRESSION  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: INCLUDING COMPRESSION  (Fujii Masao <masao.fujii@oss.nttdata.com>)
List pgsql-docs
On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
> The syntax for like_option in CREATE TABLE docs seems to forget to mention
> INCLUDING COMPRESSION option. I think the following fix is necessary.
> Patch attached.
>
> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS |
STORAGE| ALL } 
> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES |
STATISTICS| STORAGE | ALL } 

Indeed.  May I ask at the same time why gram.y (TableLikeOption) and
parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
option in alphabetical order with the rest?  Ordering them makes
easier a review of them.
--
Michael

Attachment

pgsql-docs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Typo in psql doc
Next
From: PG Doc comments form
Date:
Subject: Date/Time Functions and Operators