Postgres Pro
Downloads
Home   >   mailing lists

Improve error matching patterns in the SSL tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Improve error matching patterns in the SSL tests
Date
Msg-id YGU3AxQh0zBMMW8m@paquier.xyz
Whole thread Raw
Responses Re: Improve error matching patterns in the SSL tests  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
Hi all,

It has been mentioned twice for the last couple of days that some of
the SSL tests are not really picky with what they check, which can be
annoying when it comes to the testing of other SSL implementations as
we cannot really be sure if an error tells more than "SSL error":
https://www.postgresql.org/message-id/20210330151507.GA9536@alvherre.pgsql
https://www.postgresql.org/message-id/e0f0484a1815b26bb99ef9ddc7a110dfd6425931.camel@vmware.com

Please find attached a patch to tighten a bit all that.  The errors
produced by OpenSSL down to 1.0.1 are the same.  I have noticed one
extra place where we just check for a FATAL, where the trust
authentication failed after a CN mismatch.

Thoughts?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Crash in BRIN minmax-multi indexes
Next
From: David Rowley
Date:
Subject: Re: making update/delete of inheritance trees scale better