Re: progress reporting for partitioned REINDEX - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: progress reporting for partitioned REINDEX
Date
Msg-id YCy5ZMt8xAyoOMmv@paquier.xyz
Whole thread Raw
In response to Re: progress reporting for partitioned REINDEX  (Justin Pryzby <pryzby@telsasoft.com>)
List pgsql-hackers
On Wed, Feb 17, 2021 at 12:10:43AM -0600, Justin Pryzby wrote:
> On Wed, Feb 17, 2021 at 02:55:04PM +0900, Michael Paquier wrote:
>> I see no bug here.
>
> pg_stat_progress_create_index includes partitions_{done,total} for
> CREATE INDEX p, so isn't it strange if it wouldn't do likewise for
> REINDEX INDEX p ?

There is always room for improvement.  This stuff applies now only
when creating an index in the non-concurrent case because an index
cannot be created on a partitioned table concurrently, and this
behavior is documented as such.  If we are going to improve this area,
it seems to me that we may want to consider more cases than just the
case of partitions, as it could also help the monitoring of REINDEX on
schemas and databases.

I don't think that this fits as an open item.  That's just a different
feature.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: progress reporting for partitioned REINDEX
Next
From: Michael Paquier
Date:
Subject: Re: pg_collation_actual_version() ERROR: cache lookup failed for collation 123