Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_cryptohash_final possible out-of-bounds access (per Coverity) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)
Date
Msg-id YCnOM2bt+T1Tf4aG@paquier.xyz
Whole thread Raw
In response to Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)
List pgsql-hackers
Tree view 
On Sun, Feb 14, 2021 at 11:39:47AM -0300, Ranier Vilela wrote:
> What do you think?

That's not a good idea for two reasons:
1) There is CRC32 to worry about, which relies on a different logic.
2) It would become easier to miss the new option as compilation would
not warn anymore if a new checksum type is added.

I have reviewed my patch this morning, tweaked a comment, and applied
it.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: doing something about the broken dynloader.h symlink
Next
From: Thomas Munro
Date:
Subject: Re: shared tempfile was not removed on statement_timeout