Re: pg_cryptohash_final possible out-of-bounds access (per Coverity) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)
Date
Msg-id CAEudQAp4q+NNiBaNiwDnCcHKk_z5W5BKonXdJX5oSq=3UvBsbA@mail.gmail.com
Whole thread Raw
In response to Re: pg_cryptohash_final possible out-of-bounds access (per Coverity)  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Em dom., 14 de fev. de 2021 às 22:28, Michael Paquier <michael@paquier.xyz> escreveu:
On Sun, Feb 14, 2021 at 11:39:47AM -0300, Ranier Vilela wrote:
> What do you think?

That's not a good idea for two reasons:
1) There is CRC32 to worry about, which relies on a different logic.
2) It would become easier to miss the new option as compilation would
not warn anymore if a new checksum type is added.

I have reviewed my patch this morning, tweaked a comment, and applied
it.
Thanks for the commit.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: a misbehavior of partition row movement (?)
Next
From: Ranier Vilela
Date:
Subject: Re: Possible dereference after null check (src/backend/executor/ExecUtils.c)