Postgres Pro
Downloads
Home   >   mailing lists

Re: Strengthen pg_waldump's --save-fullpage tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Strengthen pg_waldump's --save-fullpage tests
Date
Msg-id Y7+QFYwGkz0s+xwA@paquier.xyz
Whole thread Raw
In response to Re: Strengthen pg_waldump's --save-fullpage tests  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Strengthen pg_waldump's --save-fullpage tests
Re: Strengthen pg_waldump's --save-fullpage tests
List pgsql-hackers
Tree view 
On Wed, Jan 11, 2023 at 07:17:47PM +0530, Bharath Rupireddy wrote:
> Note that the raw page on the table might differ not just in page LSN
> but also in other fields, for instance see heap_mask for instance. It
> masks lsn, checksum, hint bits, unused space etc. before verifying FPI
> consistency during recovery in
> verifyBackupPageConsistency().

FWIW, I don't really want to enter in this business here.  That feels
like a good addition of technical debt compared to the potential
gain.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Spinlock is missing when updating two_phase of ReplicationSlot
Next
From: Bharath Rupireddy
Date:
Subject: Re: Strengthen pg_waldump's --save-fullpage tests