Re: [PATCH] Add peer authentication TAP test - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add peer authentication TAP test
Date
Msg-id Y4BQO7npF41zV2lU@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add peer authentication TAP test  ("Anton A. Melnikov" <aamelnikov@inbox.ru>)
Responses Re: [PATCH] Add peer authentication TAP test
List pgsql-hackers
On Fri, Nov 25, 2022 at 07:56:08AM +0300, Anton A. Melnikov wrote:
> On Windows this test fails with error:
> # connection error: 'psql: error: connection to server at "127.0.0.1", port xxxxx failed:
> # FATAL:  no pg_hba.conf entry for host "127.0.0.1", user "buildfarm", database "postgres", no encryption'
>
> May be disable this test for windows like in 001_password.pl and 002_saslprep.pl?

You are not using MSVC but MinGW, are you?  The buildfarm members with
TAP tests enabled are drongo, fairywren, bowerbord and jacana.  Even
though none of them are running the tests from
src/test/authentication/, this is running on a periodic basis in the
CI, where we are able to skip the test in MSVC already:
postgresql:authentication / authentication/003_peer SKIP 9.73s

So yes, it is plausible that we are missing more safeguards here.

Your suggestion to skip under !$use_unix_sockets makes sense, as not
having unix sockets is not going to work for peer and WIN32 needs SSPI
to be secure with pg_regress.  Where is your test failing?  On the
first $node->psql('postgres') at the beginning of the test?  Just
wondering..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "Anton A. Melnikov"
Date:
Subject: Re: [PATCH] Add peer authentication TAP test
Next
From: Ankit Kumar Pandey
Date:
Subject: Re: Questions regarding distinct operation implementation