Re: Generate pg_stat_get_* functions with Macros - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Generate pg_stat_get_* functions with Macros
Date
Msg-id Y4/bTjgdhZRQ3JaP@paquier.xyz
Whole thread Raw
In response to Re: Generate pg_stat_get_* functions with Macros  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Tue, Dec 06, 2022 at 05:28:47AM +0100, Drouvot, Bertrand wrote:
> Fields renaming was mandatory in the previous ones as there was
> already a mix of with/without "n_" in the existing fields names.
>
> That said, I think it's better to rename the fields as you did (to
> be "consistent" on the naming between relation/db stats), so the
> patch LGTM.

Yeah, PgStat_StatDBEntry is the last one using this style, so I have
kept my change with the variables renamed rather than painting more
CppConcat()s.  The functions are still named the same as the original
ones.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Force streaming every change in logical decoding
Next
From: Jeff Davis
Date:
Subject: Collation DDL inconsistencies