Re: GUC values - recommended way to declare the C variables? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: GUC values - recommended way to declare the C variables?
Date
Msg-id Y0jd3ZNPiDQvTiMm@paquier.xyz
Whole thread Raw
In response to Re: GUC values - recommended way to declare the C variables?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: GUC values - recommended way to declare the C variables?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Oct 13, 2022 at 11:14:57PM -0400, Tom Lane wrote:
> Could we fix the out-of-sync risk by having InitializeGUCOptions insist
> that the pre-existing value of the variable match what is in guc_tables.c?
> That may not work for string values but I think we could insist on it
> for other GUC data types.  For strings, maybe the rule could be "the
> old value must be NULL or strcmp-equal to the boot_val".

pg_strcasecmp()'d would be more flexible here?  Sometimes the
character casing on the values is not entirely consistent, but no
objections to use something stricter, either.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [RFC] building postgres with meson - v13
Next
From: Tom Lane
Date:
Subject: Re: GUC values - recommended way to declare the C variables?