Re: remove redundant memset() call - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: remove redundant memset() call
Date
Msg-id Y0huL+ks7VzhZW6/@momjian.us
Whole thread Raw
In response to Re: remove redundant memset() call  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: remove redundant memset() call  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Thu, Oct 13, 2022 at 09:40:42PM +0200, Daniel Gustafsson wrote:
> > On 13 Oct 2022, at 21:18, Nathan Bossart <nathandbossart@gmail.com> wrote:
> > 
> > On Thu, Oct 13, 2022 at 03:15:13PM -0400, Bruce Momjian wrote:
> >> On Thu, Oct 13, 2022 at 12:12:35PM -0700, Zhihong Yu wrote:
> >>> the memory has been zero'ed out by palloc0().
> >>> 
> >>> memcpy is not relevant w.r.t. resetting memory.
> >> 
> >> Ah, good point.
> > 
> > Yeah, it looks like this was missed in ca7f8e2.
> 
> Agreed, it looks like I missed that one, I can't see any reason to keep it.  Do
> you want me to take care of it Bruce, and clean up after myself, or are you
> already on it?

You can do it, thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson




pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Lack of PageSetLSN in heap_xlog_visible
Next
From: Andres Freund
Date:
Subject: Re: hash_xlog_split_allocate_page: failed to acquire cleanup lock