Re: [PATCH] Allow usage of archive .backup files as backup_label - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Allow usage of archive .backup files as backup_label
Date
Msg-id Y04Hfd7z1C7E6sdj@paquier.xyz
Whole thread Raw
In response to [PATCH] Allow usage of archive .backup files as backup_label  (Michael Banck <michael.banck@credativ.de>)
Responses Re: [PATCH] Allow usage of archive .backup files as backup_label  (Laurenz Albe <laurenz.albe@cybertec.at>)
List pgsql-hackers
On Mon, Aug 22, 2022 at 05:16:58PM +0200, Michael Banck wrote:
> The .backup files written to the archive (if archiving is on) are very
> similar to the backup_label that's written/returned by
> pg_stop_backup()/pg_backup_stop(), they just have a few extra lines
> about the end of backup process that are missing from backup_label.

Historically, there is "STOP WAL LOCATION" after "START WAL LOCATION",
and "STOP TIME"/"STOP TIMELINE" at the end.

> The parser in xlogrecovery.c however barfs on them because it does not
> expect the additional STOP WAL LOCATION on line 2.

Hm, no.  I don't think that I'd want to expand the use of the backup
history file in the context of recovery, so as we are free to add any
extra information into it if necessary without impacting the
compatibility of the recovery code.  This file is primarily here for
debugging, so I'd rather let it be used only for this purpose.
Opinions of others are welcome, of course.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)
Next
From: Michael Paquier
Date:
Subject: Re: New "single-call SRF" APIs are very confusingly named