Re: Missing free_var() at end of accum_sum_final()? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Missing free_var() at end of accum_sum_final()?
Date
Msg-id Y/MjdPokh30ehc4n@paquier.xyz
Whole thread Raw
In response to Re: Missing free_var() at end of accum_sum_final()?  ("Joel Jacobson" <joel@compiler.org>)
Responses Re: Missing free_var() at end of accum_sum_final()?
List pgsql-hackers
On Sun, Feb 19, 2023 at 11:55:38PM +0100, Joel Jacobson wrote:
> To fix, a init_var() in alloc_var() is needed when we will use the
> fixed_buf instead of allocating,
> since alloc_var() could be called in a loop for existing values,
> like in sqrt_var() for instance.
>
> Attached new version produces similar benchmark results, even with the extra init_var():

Perhaps you should register this patch to the commit of March?  Here
it is:
https://commitfest.postgresql.org/42/
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: SQL/JSON revisited
Next
From: Peter Eisentraut
Date:
Subject: Re: improving user.c error messages