Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf
Date
Msg-id Y+yFjA16V+g4L+mO@paquier.xyz
Whole thread Raw
In response to Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf  (Jelte Fennema <postgres@jeltef.nl>)
Responses Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf
Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf
List pgsql-hackers
On Mon, Feb 13, 2023 at 03:13:04PM +0100, Jelte Fennema wrote:
> On Mon, 13 Feb 2023 at 15:06, Pavel Luzanov <p.luzanov@postgrespro.ru> wrote:
>> Does it make sense to reflect changes to the PG-USERNAME field in the
>> pg_ident.conf.sample file?
>>
>> The same relates to the regexp supportin the DATABASE and USER fieldsof
>> the pg_hba.conf.sample file(8fea8683).

Which comes down to blame me for both of them.

> That definitely makes sense to me. When writing the patch I didn't
> realise that there was also documentation in those files.
>
> I think it also makes sense to include usage of (some of) the features
> in the example files here:
> https://www.postgresql.org/docs/devel/auth-username-maps.html

Hmm, I am not sure that adding more examples in the sample files is
worth the duplication with the docs.

So, please find attached a patch to close the gap the sample files,
for both things, with descriptions of all the field values they can
use.

What do you think?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option
Next
From: Bharath Rupireddy
Date:
Subject: Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?