Re: recovery modules - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: recovery modules
Date
Msg-id Y+x93YToABJ9Rpxl@paquier.xyz
Whole thread Raw
In response to Re: recovery modules  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: recovery modules
List pgsql-hackers
On Mon, Feb 13, 2023 at 05:02:37PM -0800, Nathan Bossart wrote:
> Sorry for then noise, cfbot alerted me to a missing #include, which I've
> added in v13.

+   basic_archive_context = data->context;
+   Assert(CurrentMemoryContext != basic_archive_context);

So this is what it means to document that we are not in the memory
context we are freeing here.  That seems good enough to me in this
context.  Tracking if one of CurrentMemoryContext's parents is the
memory context that would be deleted would be another thing, but this
does not apply here.

I may tweak a bit the comments, but nothing more.  And I don't think I
have more to add.  Andres, do you have anything you would like to
mention?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Maciek Sakrejda
Date:
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Next
From: Amit Kapila
Date:
Subject: Re: Support logical replication of DDLs