Re: pg_waldump error message fix - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_waldump error message fix
Date
Msg-id X9bVVaGinZEusb73@paquier.xyz
Whole thread Raw
In response to Re: pg_waldump error message fix  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
On Mon, Dec 14, 2020 at 10:26:01AM +0900, Kyotaro Horiguchi wrote:
> Yeah, I had the same feeling. At least, the two LSNs in the message
> under discussion are simply redundant. So +1 to just remove the LSN at
> the caller site.

That would mean that we are ready to accept that we will never forget
to a LSN in any of the messages produced by xlogreader.c or any of the
callbacks used by pg_waldump.  FWIW, I'd rather let a position in this
report than none.  At least it allows users to know the area where the
problem happened.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "k.jamison@fujitsu.com"
Date:
Subject: RE: [Patch] Optimize dropping of relation buffers using dlist
Next
From: Michael Paquier
Date:
Subject: Re: please update ps display for recovery checkpoint