Re: Track replica origin progress for Rollback Prepared - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Track replica origin progress for Rollback Prepared
Date
Msg-id X/Wjhg4bWMlR3BbG@paquier.xyz
Whole thread Raw
In response to Re: Track replica origin progress for Rollback Prepared  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Track replica origin progress for Rollback Prepared  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Jan 05, 2021 at 04:24:21PM +0530, Amit Kapila wrote:
> There are already tests [1] in one of the upcoming patches for logical
> decoding of 2PC which covers this code using which I have found this
> problem. So, I thought those would be sufficient. I have not checked
> the feasibility of using test_decoding because I thought adding more
> using test_decoding will unnecessarily duplicate the tests.

Hmm.  This stuff does not check after replication origins even if it
stresses 2PC, so that looks incomplete when seen from here.

> How about something like "Dump transaction origin information only for
> abort prepared. We need this during recovery to update the replication
> origin progress."?

That sounds fine.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Incorrect allocation handling for cryptohash functions with OpenSSL
Next
From: Amit Kapila
Date:
Subject: Re: Track replica origin progress for Rollback Prepared