Re: Track replica origin progress for Rollback Prepared - Mailing list pgsql-hackers

On Tue, Jan 05, 2021 at 09:35:21AM +0530, Amit Kapila wrote:
> As noted in [1], without this the subscriber might again ask for
> rollback prepared lsn after restart.
>
> Attached patch addresses this problem.

Is it possible to add some tests in test_decoding?

    /* dump transaction origin information only for abort prepared */
    if ((replorigin_session_origin != InvalidRepOriginId) &&
-               TransactionIdIsValid(twophase_xid) &&
-               XLogLogicalInfoActive())
+               TransactionIdIsValid(twophase_xid))
It seems to me that you may want to document as a comment the reason
why this gets sent even if (wal_level < logical).
--
Michael