[pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong - Mailing list pgadmin-hackers

From zhangjie2@fujitsu.com
Subject [pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong
Date
Msg-id TYWPR01MB7678AC09EB538FC37162B1EFF9E49@TYWPR01MB7678.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: [pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong
List pgadmin-hackers
Hi, all

SharedServersGetTestCase can only be tested in SERVER mode.
So, in Desktop mode, prompt information will be output.
However, the prompt is wrong.  
("Can not run shared servers test cases in the SERVER mode.")

I think it should be changed to the following prompt information
"Can not run shared servers test cases in the Desktop mode."

----------------------------------------------------------------------------
file: web\pgadmin\browser\server_groups\servers\tests\test_shared_server.py

SharedServersGetTestCase

    def setUp(self):
        """This function add the server to test the GET API"""

        if config.SERVER_MODE is False:
            self.skipTest(
                "Can not run shared servers test cases in the SERVER mode."  ※
            )
----------------------------------------------------------------------------

Here is a patch for test_shared_server.py
Please review.

Best Regards!
Zhangjie




Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Bug #6337 Patch
Next
From: Nikhil Mohite
Date:
Subject: [pgAdmin][RM-6574]: The paste is not working through Right-Click option on PSQL