On Wednesday, February 23, 2022 6:52 PM Tang, Haiying/唐 海英 <tanghy.fnst@fujitsu.com> wrote:
> I have a comment on v21 patch.
>
> I wonder if we really need subscription s2 in 028_disable_on_error.pl. I think for
> subscription s2, we only tested some normal cases(which could be tested with
> s1), and didn't test any error case, which means it wouldn't be automatically
> disabled.
> Is there any reason for creating subscription s2?
Hi, thank you for your review !
It's for checking there's no impact/influence when disabling one subscription
on the other subscription if any.
*But*, when I have a look at the past tests to add options (e.g. streaming,
two_phase), we don't have this kind of test that I have for disable_on_error patch.
Therefore, I'd like to fix the test as you suggested in my next version.
Best Regards,
Takamichi Osumi
