RE: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t" - Mailing list pgsql-hackers

From kuroda.hayato@fujitsu.com
Subject RE: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
Date
Msg-id TYAPR01MB5866BC2B1E268A1A19D69677F5559@TYAPR01MB5866.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
List pgsql-hackers
Dear Michael,

> Done this one.  I have scanned the code, but did not notice a similar
> mistake.

I found your commit, thanks!

> It is worth noting that we have only one remaining "volatile
> bool" in the headers now.

Maybe you mentioned about sigint_interrupt_enabled,
and it also seems to be modified in the signal handler.
But I think any race conditions may be not occurred here
because if the value is set in the handler the code jump will be also happened.

Of course it's OK to mark the variable to sig_atomic_t too if there is no problem.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED




pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: kerberos/001_auth test fails on arm CPU darwin
Next
From: Andrey Chudnovsky
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER