RE: Is this a problem in GenericXLogFinish()? - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Is this a problem in GenericXLogFinish()?
Date
Msg-id TYAPR01MB58667885EE61EFB2844820DDF5AAA@TYAPR01MB5866.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Is this a problem in GenericXLogFinish()?  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Is this a problem in GenericXLogFinish()?  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
Dear Amit, Michael,

Thanks for making the patch!

> Why register wbuf at all if there are no tuples to add and it is not
> the same as bucketbuf? Also, I think this won't be correct if prevbuf
> and wrtbuf are the same and also we have no tuples to add to wbuf. I
> have attached a naive and crude way to achieve it. This needs more
> work both in terms of trying to find a better way to change the code
> or ensure this won't break any existing case. I have just run the
> existing tests. Such a fix certainly required more testing.

I'm verifying the idea (currently it seems OK), but at least there is a coding error -
wbuf_flags should be uint8 here. PSA the fixed patch.


Best Regards,
Hayato Kuroda
FUJITSU LIMITED


Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Support run-time partition pruning for hash join
Next
From: zhihuifan1213@163.com
Date:
Subject: Re: Extract numeric filed in JSONB more effectively