RE: Should consider materializing the cheapest inner path in consider_parallel_nestloop() - Mailing list pgsql-hackers

From Fujii.Yuki@df.MitsubishiElectric.co.jp"
Subject RE: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
Date
Msg-id TYAPR01MB30884712D2366CF5F693529095F92@TYAPR01MB3088.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()  (Tender Wang <tndrwang@gmail.com>)
Responses Re: Should consider materializing the cheapest inner path in consider_parallel_nestloop()
List pgsql-hackers
Hi. Tender.

Thank you for modification.

> From: Tender Wang <tndrwang@gmail.com>
> Sent: Tuesday, June 4, 2024 7:51 PM
>     Please add more tests.  Especially please add some negative tests;
>     current patch checks that it is safe to apply materialization. It would
>     be helpful to add tests checking that materialization is not applied
>     in both checked cases:
>     1. when inner join path is not parallel safe
>     2. when matpath is not parallel safe
> 
> 
> 
> I added a test case that inner rel is not parallel safe. Actually, 
> matpath will not create if inner rel is not parallel safe. So I didn't add test case for the second  scenario.
Is there case in which matpath is not parallel safe and inner rel is parallel safe?
If right, I think that it would be suitable to add a negative test in a such case.

Sincerely yours,
Yuuki Fujii

--
Yuuki Fujii
Information Technology R&D Center Mitsubishi Electric Corporation



pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding
Next
From: Bruce Momjian
Date:
Subject: Re: Partial aggregates pushdown