RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently
Date
Msg-id TYAPR01MB2990BFBF8172C18627E55A88FECC0@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently
List pgsql-hackers
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
> But what happens when you create another partition after you change the
> "loggedness" of the partitioned table?

The new partition will have a property specified when the user creates it.  That is, while the storage property of each
storageunit (=partition) is basically independent, ALTER TABLE on a partitioned table is a convenient way to set the
sameproperty value to all its underlying storage units. 


> Well, my main take from that is we should strive to change all
> subcommands together, in some principled way, rather than change only
> one or some, in arbitrary ways.

I got an impression from the discussion that some form of consensus on the principle was made and you were trying to
createa fix for REPLICA IDENTITY.  Do you think the principle was unclear and we should state it first (partly to
refreshpeople's memories)? 

I'm kind of for it, but I'm hesitant to create the fix for all ALTER actions, because it may take a lot of time and
energyas you were afraid.  Can we define the principle, and then create individual fixes independently based on that
principle?


Regards
Takayuki Tsunakawa




pgsql-hackers by date:

Previous
From:
Date:
Subject: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion
Next
From: Michael Paquier
Date:
Subject: Re: small cleanup in unicode_norm.c