RE: POC: postgres_fdw insert batching - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: POC: postgres_fdw insert batching
Date
Msg-id TYAPR01MB2990893AD1D67A6267A2C380FEA80@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: POC: postgres_fdw insert batching  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-hackers
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
> FWIW the attached v8 patch does this - most of the conditions are moved to the
> GetModifyBatchSize() callback. I've removed the check for the BatchInsert
> callback, though - the FDW knows whether it supports that, and it seems a bit
> pointless at the moment as there are no other batch callbacks. Maybe we
> should add an Assert somewhere, though?

Thank you.  I'm in favor this idea that the decision to support RETURNING and trigger is left to the FDW.  I don' think
ofthe need for another Assert, as the caller has one for the returned batch size.
 


Regards
Takayuki Tsunakawa


pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: A failure of standby to follow timeline switch
Next
From: "Hou, Zhijie"
Date:
Subject: RE: remove unneeded pstrdup in fetch_table_list