Postgres Pro
Downloads
Home   >   mailing lists

RE: [Patch] Optimize dropping of relation buffers using dlist - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: [Patch] Optimize dropping of relation buffers using dlist
Date
Msg-id TYAPR01MB2990075665B80759D2D0246AFE290@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: [Patch] Optimize dropping of relation buffers using dlist  ("tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>)
List pgsql-hackers
Tree view 
From: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
> (1)
> +                    INIT_BUFFERTAG(newTag,
> rnode.node, forkNum[j], firstDelBlock[j]);
> 
> And you need to use i here, too.

I remember the books "Code Complete" and/or "Readable Code" suggest to use meaningful loop variable names like fork_num
andblock_count, to prevent this type of mistakes.
 


Regards
Takayuki Tsunakawa

pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: Auto-vectorization speeds up multiplication of large-precision numerics
Next
From: Amit Kapila
Date:
Subject: Inconsistency in determining the timestamp of the db statfile.