RE: Wrong statistics for size of XLOG_SWITCH during pg_waldump. - Mailing list pgsql-hackers

From
Subject RE: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
Date
Msg-id TYAPR01MB28966A71B35D1E22FE9450AFC4689@TYAPR01MB2896.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.  (David Steele <david@pgmasters.net>)
Responses Re: Wrong statistics for size of XLOG_SWITCH during pg_waldump.
List pgsql-hackers
>>>But 0 value maybe looks strange, so in current version I show it like >below:
>>>Type N (%) Record size (%) FPI size (%) Combined size (%)
>>>---- - --- ----------- --- -------- --- ------------- --- ...
>>>XLOG/SWITCH_JUNK - ( -) 11006248 ( 72.26) - ( -) 11006248 ( 65.78)
>>>Transaction/COMMIT 10 ( 0.03) 340 ( 0.00) 0 ( 0.00) 340 ( 0.00)
>>
>> I just wanted to know why the "count" and "fpi_len" fields 0 are.
>> So, it would be nice to have 0 values. Sorry for confusing you.
>
>Kato, it's not clear to me if you were asking for - to be changed back to 0?
>
>You marked the patch as Ready for Committer so I assume not, but it would be
>better to say clearly that you think this patch is ready for a committer to look at.

Yes, I don't think it needs to be changed back to 0.
I think this patch is ready for a committer to look at.

Regards,
Shinya Kato



pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: Logical Replication vs. 2PC
Next
From: Bharath Rupireddy
Date:
Subject: Re: A new function to wait for the backend exit after termination