Re: Duplicate function call on timestamp2tm - Mailing list pgsql-hackers

From Li Japin
Subject Re: Duplicate function call on timestamp2tm
Date
Msg-id SG2PR06MB3776DC04EA41E8FDC509B36CB6550@SG2PR06MB3776.apcprd06.prod.outlook.com
Whole thread Raw
In response to Re: Duplicate function call on timestamp2tm  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Duplicate function call on timestamp2tm  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Thanks for your confirm. Is there anything I can do?

On Dec 12, 2019, at 11:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Ah, after looking in the git history, not quite that ancient:
this duplication dates to commit 258ee1b63, which moved these
switch cases from the "if (type == RESERV)" switches in the
same functions.  In the previous coding these function calls
were actually necessary, but here they're redundant.  I guess
that's just additional ammunition for Greg's point that the
keywords were misclassified ;-).

pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: Make autovacuum sort tables in descending order of xid_age
Next
From: Amit Khandekar
Date:
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files