Re: Ultrix port - Mailing list pgsql-hackers

From Alexander Klimov
Subject Re: Ultrix port
Date
Msg-id Pine.SUN.4.21.0103291112340.13745-100000@dardar.wisdom.weizmann.ac.il
Whole thread Raw
In response to Re: Ultrix port  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, 27 Mar 2001, Tom Lane wrote:

> Alexander Klimov <ask@wisdom.weizmann.ac.il> writes:
> > First problem is sys/socket.h. Here it has no guards in it (like 
> > #ifdef _SOCKET_H
> > #endif), so it could not be included twice, and I have to remove its
> > unnecesarry inclusions.
> 
> Are you sure these are unnecessary?  What are the odds this patch will
> break other platforms?
I almost shure it is not, because sys/socket.h already included in each of
the files but indirectly, thru libpq-be -> pqcomm, that include it on non
windows platforms. My guess is that tracking and elimination of double
includes of the same file is useful in general, because it at
least decrease compilation time.

Regards,
ASK



pgsql-hackers by date:

Previous
From: Adriaan Joubert
Date:
Subject: ecpg autocommit weirdness
Next
From: Karel Zak
Date:
Subject: Re: [ADMIN] Re: Re: [PORTS] pgmonitor and Solaris