Re: Cleaning up unreferenced table files - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: Cleaning up unreferenced table files
Date
Msg-id Pine.OSF.4.61.0504271721060.70462@kosh.hut.fi
Whole thread Raw
In response to Re: Cleaning up unreferenced table files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Wed, 27 Apr 2005, Tom Lane wrote:

> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> On Tue, 26 Apr 2005, Tom Lane wrote:
>>> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>>>> I feel that crashes that leaves behind stale files are rare.
>>>
>>> Indeed, and getting more so all the time ...
>
>> How so? Have changes been made in those parts of the code?
>
> No, just that the overall reliability of Postgres keeps improving.
>
> At the time that TODO entry was created, I don't think we even had the
> ability to roll back table creates/drops properly, so there were
> scenarios in which unreferenced files could be left behind without even
> assuming any software error.  And the prevalence of backend crashes was
> way higher than it is now, too.  So I think a good argument could be
> made that the TODO item isn't nearly as important as it was at the time.

*shrug*. I won't push any harder if you feel strongly against the patch.

Should we just remove the TODO item? And/or document the issue?

- Heikki

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaning up unreferenced table files
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Continue transactions after errors in psql