Re: Cleaning up unreferenced table files - Mailing list pgsql-patches

From Heikki Linnakangas
Subject Re: Cleaning up unreferenced table files
Date
Msg-id Pine.OSF.4.61.0504271629090.70462@kosh.hut.fi
Whole thread Raw
In response to Re: Cleaning up unreferenced table files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Cleaning up unreferenced table files
List pgsql-patches
On Tue, 26 Apr 2005, Tom Lane wrote:

> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> I feel that crashes that leaves behind stale files are rare.
>
> Indeed, and getting more so all the time ...

How so? Have changes been made in those parts of the code?

> which makes me question the value of doing anything about this at all.

What bothers me is that we currently have no means of knowing if it
happens and how often it happens, so we're just guessing that "it's
rare". How rare? We don't know.

If nobody ever runs into this issue in production, and this whole exercise
turns out to be completely unnecessary, at least we'll know. That alone
makes me feel better.

The only drawback of the patch that I can see is the performance impact on
recovery. And I think the time it takes to scan the data directories isn't
much compared to WAL replay.

- Heikki

pgsql-patches by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Cleaning up unreferenced table files
Next
From: Tom Lane
Date:
Subject: Re: Cleaning up unreferenced table files