Enabling --debug causes regression test failure. - Mailing list pgsql-bugs

From Bill Studenmund
Subject Enabling --debug causes regression test failure.
Date
Msg-id Pine.NEB.4.33.0110221205330.6662-300000@vespasia.home-net.internetconnect.net
Whole thread Raw
Responses Re: Enabling --debug causes regression test failure.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
If PostgreSQL failed to compile on your computer or you found a bug that
is likely to be specific to one platform then please fill out this form
and e-mail it to pgsql-ports@postgresql.org.

To report any other bug, fill out the form below and e-mail it to
pgsql-bugs@postgresql.org.

If you not only found the problem but solved it and generated a patch
then e-mail it to pgsql-patches@postgresql.org instead.  Please use the
command "diff -c" to generate the patch.

You may also enter a bug report at http://www.postgresql.org/ instead of
e-mail-ing this form.

============================================================================
                        POSTGRESQL BUG REPORT TEMPLATE
============================================================================


Your name        :    Bill Studenmund
Your email address    :    wrstuden@netbsd.org


System Configuration
---------------------
  Architecture (example: Intel Pentium)      : Intel Pentium

  Operating System (example: Linux 2.0.26 ELF)     : NetBSD 1.5.2

  PostgreSQL version (example: PostgreSQL-7.1.1):   PostgreSQL-7.2devel

  Compiler used (example:  gcc 2.95.2)        :


Please enter a FULL description of your problem:
------------------------------------------------

Enabling --debug while running regression tests notes regression test
failures which are not present when --debug is not enabled.

The foreign_key test fails, when it succeeds w/o --debug. I've attached
the output of regression.diff.



Please describe a way to repeat the problem.   Please try to provide a
concise reproducible example, if at all possible:
----------------------------------------------------------------------

cd src/tests/regression; gmake check; Apply the patch to GNUmakefile I've
attached and gmake check. Note that the foreign_key test fails.

Node type 725 is, according to include/nodes/nodes.h, T_FkConstraint.
Probably what happened was that when tgl added the node type (revision
1.68 of this file), he didn't add a T_FkConstraint clause to
backend/nodes/outfuncs.c:_outNode(). There will probably also need to be a
way for the output to be read back in.



If you know how this problem might be fixed, list the solution below:
---------------------------------------------------------------------

src/backend/nodes/outfuncs.c:_outNode() needs to be able to dump a foreign
key contraint. Also an FK constraint will need to be parsed when the plan
is read back in.

pgsql-bugs by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: ALL in SELECT syntax \h psql flawed?
Next
From: Arguile
Date:
Subject: New default ignored by pre-exising insert rulesets.