S_LOCK() change produces error... - Mailing list pgsql-hackers

From The Hermit Hacker
Subject S_LOCK() change produces error...
Date
Msg-id Pine.NEB.3.96.980117213702.259C-100000@thelab.hub.org
Whole thread Raw
Responses Re: [HACKERS] S_LOCK() change produces error...  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
I installed some patches today for the univel port, and one of the changes
did the following to include/storage/s_lock.h:

302c318
<                               __asm__("xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \
---
>                               __asm__("lock xchgb %0,%1": "=q"(_res), "=m"(*lock):"0"(0x1)); \


Under FreeBSD, this breaks the compile with an 'unimplemented' error...I'm
not going to commit the "fix" yet (reverse the patch)...does this break other
ports as well, or just FreeBSD?  Anyone with Assembler experience out there? :)


Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org


pgsql-hackers by date:

Previous
From: darrenk@insightdist.com (Darren King)
Date:
Subject: Re: [HACKERS] Re: [QUESTIONS] Business cases
Next
From: The Hermit Hacker
Date:
Subject: free() error in current source tree under FreeBSD...