Re: FW: OID, compatible=7.1 and getBinaryStream() in - Mailing list pgsql-jdbc

From Kris Jurka
Subject Re: FW: OID, compatible=7.1 and getBinaryStream() in
Date
Msg-id Pine.LNX.4.33.0312171910500.13414-300000@leary.csoft.net
Whole thread Raw
In response to Re: FW: OID, compatible=7.1 and getBinaryStream() in  (Dave Cramer <pg@fastcrypt.com>)
Responses Re: FW: OID, compatible=7.1 and getBinaryStream() in
List pgsql-jdbc

On 17 Dec 2003, Dave Cramer wrote:

> patched and backpatched,

The test case you've added has some issues:

1) It has a fixed connection string instead of using the connection
parameters from TestUtil.
2) It prints output to standard out instead of using asserts
3) It has the original comments describing the bug which are confusing if
you expect the test to pass.
4) It uses windows end of line characters.

This patch fixes these issues.

Additionally doing some testing revealed another bug with compatibilty
version handling.  If the user does not explicitly specify a "compatible"
parameter it defaults to the jdbc driver version.  It should instead
default to the server version the connection is for because a newer driver
can talk to older databases.

I've attached a patch for this as well.

Kris Jurka


Attachment

pgsql-jdbc by date:

Previous
From: Dave Cramer
Date:
Subject: Re: FW: OID, compatible=7.1 and getBinaryStream() in
Next
From: Kris Jurka
Date:
Subject: Missing patches on 7.4 branch.