Re: PAM patch... - Mailing list pgsql-patches

From Dominic J. Eidson
Subject Re: PAM patch...
Date
Msg-id Pine.LNX.4.33.0202212303250.2725-100000@morannon.the-infinite.org
Whole thread Raw
In response to Re: PAM patch...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Fri, 22 Feb 2002, Tom Lane wrote:

> I think that the coding pattern shown in lines 746-760 is good:
>
>     retval = pam_something(params);
>
>     if (retval != PAM_SUCCESS)
>     {
>         generate error message;
>         clean up state as needed;
>         return STATUS_ERROR;
>     }
>
> and that the right fix is to make each of the subsequent calls be in
> this same pattern, not to try to emulate their nonsensical style.

That's fair - there was some (weird?) reason it was done the other way in
the example code I based that section off of, but I don't remember
specifically why.

I'll make those changes, and resubmit.


--
Dominic J. Eidson
                                        "Baruk Khazad! Khazad ai-menu!" - Gimli
-------------------------------------------------------------------------------
http://www.the-infinite.org/              http://www.the-infinite.org/~dominic/


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: PAM patch...
Next
From: "Dominic J. Eidson"
Date:
Subject: Re: PAM patch...