Re: Fix for defaults in createuser - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: Fix for defaults in createuser
Date
Msg-id Pine.LNX.4.30.0101211152550.757-100000@peter.localdomain
Whole thread Raw
In response to Fix for defaults in createuser  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Fix for defaults in createuser  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian writes:

> !       if [ $REPLY = "y" -o $REPLY = "Y" ]; then
>
> fixed to:
>
> !       if [ "$REPLY" = "y" -o "$REPLY" = "Y" ]; then

Good.

FYI, it's never necessary to quote the right side of a shell variable
assignment.

FOO=$BAR

always works, as does

case $foo in ...

But it doesn't hurt of course.

--
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Re: Patch to support transactions with BLOBs for current CVS
Next
From: Bruce Momjian
Date:
Subject: Re: Fix for defaults in createuser