Re: GSS warnings - Mailing list pgsql-patches

From Kris Jurka
Subject Re: GSS warnings
Date
Msg-id Pine.BSO.4.64.0709051258580.30413@leary.csoft.net
Whole thread Raw
In response to Re: GSS warnings  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: GSS warnings  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches

On Wed, 5 Sep 2007, Tom Lane wrote:

> Kris Jurka <books@ejurka.com> writes:
>> Parts of the GSS API want the object while others want pointers to the
>> object and it looks like this code got it backwards.  I haven't tested
>> these changes, but they look right to me.
>
> Wouldn't the code fail entirely if it was wrong in that way?
>

Only if it was ever run.  My suspicion is that Port->gss->ctx/cred are
never set to anything other than GSS_C_NO_CONTEXT and GSS_C_NO_CREDENTIAL.
This patch also clarifies the checking we're doing on cleanup to be
more clear about whether these are pointers or not.

Kris Jurka

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Lazy xid assignment V4
Next
From: Teodor Sigaev
Date:
Subject: Re: tsearch refactorings