Re: patch adding new regexp functions - Mailing list pgsql-patches

From Jeremy Drake
Subject Re: patch adding new regexp functions
Date
Msg-id Pine.BSO.4.64.0702091631080.28908@resin.csoft.net
Whole thread Raw
In response to Re: patch adding new regexp functions  (Neil Conway <neilc@samurai.com>)
Responses Re: patch adding new regexp functions  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
On Fri, 9 Feb 2007, Neil Conway wrote:

> The "doing_srf" business is rather tortured, and seems an invitation for
> bugs. ISTM there should be a cleaner way to implement this. For example,
> would it be possible to put all the common logic into one or more
> additional functions, and then have SRF vs. non-SRF cases that call into
> those functions after doing the appropriate initialization?

Here is a new version of the patch which eliminates the doing_srf stuff.
It does seem a lot cleaner this way...

--
Fortune's Real-Life Courtroom Quote #18:

Q:  Are you married?
A:  No, I'm divorced.
Q:  And what did your husband do before you divorced him?
A:  A lot of things I didn't know about.

Attachment

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: patch adding new regexp functions
Next
From: Neil Conway
Date:
Subject: Re: patch adding new regexp functions