Re: pgsql: Allow psql multi-line column values to align - Mailing list pgsql-committers

From Kris Jurka
Subject Re: pgsql: Allow psql multi-line column values to align
Date
Msg-id Pine.BSO.4.61.0602100151570.23655@leary.csoft.net
Whole thread Raw
In response to pgsql: Allow psql multi-line column values to align in the proper  (momjian@postgresql.org (Bruce Momjian))
Responses Re: pgsql: Allow psql multi-line column values to align  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-committers

On Thu, 9 Feb 2006, Bruce Momjian wrote:

> Log Message:
> -----------
> Allow psql multi-line column values to align in the proper columns
>

There is a problem with this on AIX.

http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=asp&dt=2006-02-10%2006:23:00

For tables that have no columns AIX thinks it has an out of memory error.
src/bin/psql/print.c:pg_local_calloc bails out if calloc returns NULL.  I
believe AIX is returning NULL for calloc with a count of zero.  Efforts
are made not to call pg_local_calloc with a count of zero, but one place
is missed, the attached patch fixes that.

Additionally there are a whole lot of of signedness warnings introduced
which I've attached.

Kris Jurka

Attachment

pgsql-committers by date:

Previous
From: Kris Jurka
Date:
Subject: Re: pgsql: Allow psql multi-line column values to align
Next
From: teodor@postgresql.org (Teodor Sigaev)
Date:
Subject: pgsql: renew output of regression test accordingly to