On Mon, 3 Oct 2005, Russell Francis wrote:
> I have completed what I think is a stable and well tested addition to
> the JDBC driver for PG's extended network based types inet, cidr and macaddr.
>
I haven't fully reviewed this patch, but I'm going on vacation for two
weeks tomorrow, so I wanted to at least get back to you with my initial
observations.
1) It fails to pass the tests you've provided:
[junit] Testcase: testPGinetIPv4InvalidAddresses(org.postgresql.test.net.PGinetTest): FAILED
[junit] An invalid address was turned into a PGinet object: 255.255.1/23' failed.
[junit] junit.framework.AssertionFailedError: An invalid address was turned into a PGinet object: 255.255.1/23'
failed.
[junit] at org.postgresql.test.net.PGinetTest.testPGinetIPv4InvalidAddresses(PGinetTest.java:70)
2) It uses Inet[4|6]Address which is only available in JDK1.4+ while the
driver must compile with JDK1.2.
Kris Jurka
