Re: [HACKERS] xlog.c.patch for cygwin port. - Mailing list pgsql-hackers

From The Hermit Hacker
Subject Re: [HACKERS] xlog.c.patch for cygwin port.
Date
Msg-id Pine.BSF.4.21.0003080141310.591-100000@thelab.hub.org
Whole thread Raw
In response to Re: [HACKERS] xlog.c.patch for cygwin port.  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] xlog.c.patch for cygwin port.  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
On Tue, 7 Mar 2000, Bruce Momjian wrote:

> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > This looks interesting.  We could remove some of our ifwin cruft.
> > 
> > I have been thinking for quite some time that most of the CYGWIN32
> > ifdefs represent very poor programming.  Instead of zillions of
> > 
> > #ifndef __CYGWIN32__
> >     fd = open(filename, O_RDONLY, 0666);
> > #else
> >     fd = open(filename, O_RDONLY | O_BINARY, 0666);
> > #endif
> > 
> > we should have in one include file something like
> 
> Do we ever assign a function pointer for open() anywhere.  If so, the
> define will not work without some kind of wrapper, right?

Okay, I'm lost ... if we "#define OPEN_FLAGS .." and not the open itself,
why would we need some kind of wrapper?




pgsql-hackers by date:

Previous
From: Thomas Lockhart
Date:
Subject: Re: BIT/BIT VARYING names (was Re: [HACKERS] Beta for 4:30AST)
Next
From: Thomas Lockhart
Date:
Subject: Re: [HACKERS] DROP TABLE inside a transaction block