Patch is applied and committed...
On Fri, 6 Feb 1998, Tom I Helbekkmo wrote:
> On Wed, 4 Feb 1998, Bruce Momjian wrote:
>
> > I certainly think we want those changes. 6.3 beta is the place we
> > expect to be making platform-specific patches.
>
> ...and here they are. There are only small modifications, but there
> is one that requires a decision to be made: NetBSD/vax does not have
> shared libraries, and it thus introduces a situation where a single
> "port" has internal differences in this regard. What I've chosen to
> do is to add a kludge to Makefile.global, identical in function to the
> LINUX_ELF kludge. I think this acceptable -- you may disagree.
>
> Apart from this Makefile hack, all I've done is to make dynamically
> loaded code modules fail properly (as was already done for __mips__,
> although I think this is too loose: I believe NetBSD for the pmax can
> do dynamic linking), and to add test-and-set lock handling. As Bruce
> suggested, this is done in a maximally efficient inlined way: I was
> not aware that this code was so important, speed-wise.
>
> Oh, and Bruce: I figured out why we talked past each other about the
> lock code and inlining: I was looking at the Sparc assembly code in
> s_lock.h, since my main platform is NetBSD/sparc, and if you take a
> look at that, you'll see that it's _not_ inlined, and not pretty. In
> fact, it breaks at -O3 and up by causing linking to fail, when GCC
> eliminates the whole tas_dummy() function, since it's static and not
> called by anything else. I've tried to figure out how to inline it,
> but I don't know enough about the Sparc. Besides, RISC machines were
> never meant to be programmed by anything but a computer. :-)
>
> Anyway, this is all it takes to make things work on NetBSD/vax (note
> the _single_ instruction used to implement the test-and-set -- it's
> only one of _six_ such instructions in this powerful architecture):
>
Marc G. Fournier
Systems Administrator @ hub.org
primary: scrappy@hub.org secondary: scrappy@{freebsd|postgresql}.org
