RE: Handle infinite recursion in logical replication setup - Mailing list pgsql-hackers

From shiy.fnst@fujitsu.com
Subject RE: Handle infinite recursion in logical replication setup
Date
Msg-id OSZPR01MB63108121E8E20AF9E87B466BFD7B9@OSZPR01MB6310.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Handle infinite recursion in logical replication setup  (vignesh C <vignesh21@gmail.com>)
Responses Re: Handle infinite recursion in logical replication setup
List pgsql-hackers
On Wed, Aug 31, 2022 1:06 AM vignesh C <vignesh21@gmail.com> wrote:
> 
> The attached v43 patch has the changes for the same.
> 

Thanks for updating the patch.

Here is a comment on the 0001 patch.

+        if (!isnewtable)
+        {
+            pfree(nspname);
+            pfree(relname);
+            continue;
+        }

If it is a new table, in which case it would log a warning, should we also call
pfree()?

Regards,
Shi yu

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Add native windows on arm64 support
Next
From: Jeff Janes
Date:
Subject: Re: num_sa_scans in genericcostestimate