RE: Time delayed LR (WAS Re: logical replication restrictions) - Mailing list pgsql-hackers

From shiy.fnst@fujitsu.com
Subject RE: Time delayed LR (WAS Re: logical replication restrictions)
Date
Msg-id OSZPR01MB631003E2729310B412199EB3FDAB9@OSZPR01MB6310.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: Time delayed LR (WAS Re: logical replication restrictions)  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: Time delayed LR (WAS Re: logical replication restrictions)
List pgsql-hackers
On Wed, Feb 22, 2023 9:48 PM Kuroda, Hayato/黒田 隼人 <kuroda.hayato@fujitsu.com> wrote:
> 
> Thank you for reviewing! PSA new version.
> 

Thanks for your patch. Here is a comment.

+        elog(DEBUG2, "time-delayed replication for txid %u, delay_time = %d ms, remaining wait time: %ld ms",
+             ctx->write_xid, (int) ctx->min_send_delay,
+             remaining_wait_time_ms);

I tried and saw that the xid here looks wrong, what it got is the xid of the
previous transaction. It seems `ctx->write_xid` has not been updated and we
can't use it.

Regards,
Shi Yu

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pg_regress: Treat child process failure as test failure
Next
From: "shiy.fnst@fujitsu.com"
Date:
Subject: RE: Allow logical replication to copy tables in binary format