Dear Alexander,
>
> Good idea. But I think we should associate the "updated" flag
> directly to the fact that one slot (no matter logical or physical)
> changed its last_saved_restart_lsn. See the attached patch. I'm
> going to push it if no objections.
+ /*
+ * Track if we're going to update slot's last_saved_restart_lsn.
+ * We need this to know if we need to recompute the required LSN.
+ */
+ if (s->last_saved_restart_lsn != s->data.restart_lsn)
+ last_saved_restart_lsn_updated = true;
I feel no need to set to true if last_saved_restart_lsn_updated is already true.
Other than that it's OK for me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
