Postgres Pro
Downloads
Home   >   mailing lists

RE: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots
Date
Msg-id OSCPR01MB14966872023DFE8F4454DEB13F5E92@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Improve error handling for invalid slots and ensure a same 'inactive_since' time for inactive slots  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
Tree view 
Dear Nisha,

Thanks for creating a patch!

> Removed patch v1-0001. Please find the attached version 2 of 0002,
> which is now v2-0001.

ISMT error_if_invalid is set to true when the slot is using and set to false when dropping.
One exception is the slot_sync, but it has already had mechanism to handle such a slot.

I confirmed RaiseSlotInvalidationError() is removed based on comments.
I ran regression tests on my env and passed.

In total the patch looks good to me.

----------
Best regards,
Haato Kuroda

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Skip collecting decoded changes of already-aborted transactions
Next
From: Peter Smith
Date:
Subject: Re: Skip collecting decoded changes of already-aborted transactions