RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly
Date
Msg-id OSCPR01MB149666CB55DBC2170B1BA9F12F545A@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
Dear Alexander,

> Regarding last_saved_restart_lsn_updated, I think the opposite.  I
> think we should check if last_saved_restart_lsn_updated is set already
> only if it could promise us some economy of resources.  In our case
> the main check only compares two fields of slot.  And that fields are
> to be accessed anyway.  So, we are not going to save any RAM accesses.
> Therefore, checking for last_saved_restart_lsn_updated seems like
> unnecessary code complication (and I don't see we're doing that in
> other places).  So, I'm going to push this patch "as is".

To clarify: I have no objections. Thanks for giving the knowledge.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: SQL:2023 JSON simplified accessor support
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Conflict detection for update_deleted in logical replication