RE: Some codes refer slot()->{'slot_name'} but it is not defined - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Some codes refer slot()->{'slot_name'} but it is not defined
Date
Msg-id OSCPR01MB149665DBB57C5C835143E75DCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Some codes refer slot()->{'slot_name'} but it is not defined  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Some codes refer slot()->{'slot_name'} but it is not defined
List pgsql-hackers
Dear Fujii-san,

> -is($node_primary->slot('dropme_slot')->{'slot_name'},
> -    undef, 'logical slot was actually dropped on standby');
> +is($node_primary->slot('dropme_slot')->{'plugin'},
> +    '', 'logical slot was actually dropped on standby');
> 
> This seems like a separate issue from what your patch is addressing,
> but since this test is meant to confirm that the slot was dropped
> on the standby, shouldn't node_primary be node_replica instead?

You are right. It has been missed 8 years ago, let's fix now.

BTW, the issue exists for all supported branches. How do you feel
to backpatch them? PSA all patch set.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Detach partition with constraint test
Next
From: Jakub Wartak
Date:
Subject: Re: Draft for basic NUMA observability